Honour listall param for list templates api by vishesh92 · Pull Request #9300 · apache/cloudstack

vishesh92 · 2024-06-25T08:33:03Z

Description

This PR makes changes to honour listall param for list templates api and also adds the listall parameter to deployVM in the UI.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

vishesh92 · 2024-06-25T08:34:44Z

@blueorangutan package

blueorangutan · 2024-06-25T08:36:04Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2024-06-25T08:41:41Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.28%. Comparing base (620ed16) to head (b9a6ec7).
Report is 5 commits behind head on 4.19.

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19   #9300       +/-   ##
============================================
- Coverage     14.95%   4.28%   -10.68%     
============================================
  Files          5387     364     -5023     
  Lines        470348   29439   -440909     
  Branches      58589    5146    -53443     
============================================
- Hits          70330    1260    -69070     
+ Misses       392224   28036   -364188     
+ Partials       7794     143     -7651

Flag	Coverage Δ
uitests	`4.28% <ø> (-0.01%)`	⬇️
unittests	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sureshanaparti

clgtm

blueorangutan · 2024-06-25T09:37:31Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10110

slavkap · 2024-06-25T10:58:28Z

I'm not sure how to properly test this, but here are the results from a few scenarios:
1 - I've created a project and downloaded a template. When I open the deploy VM wizard I can see it.
2 - I've created another project, and when I open the wizard I see the template of the first project
3 - when I open the default view and try to deploy a VM I see only the template from the first project, but I have a few more when I list them from the Image tab
4 - I've deleted the projects and have only the default view, and there aren't any templates listed when using the Deploy VM wizard

vishesh92 · 2024-06-25T12:59:44Z

I'm not sure how to properly test this, but here are the results from a few scenarios: 1 - I've created a project and downloaded a template. When I open the deploy VM wizard I can see it. 2 - I've created another project, and when I open the wizard I see the template of the first project 3 - when I open the default view and try to deploy a VM I see only the template from the first project, but I have a few more when I list them from the Image tab 4 - I've deleted the projects and have only the default view, and there aren't any templates listed when using the Deploy VM wizard

Thanks @slavkap . This is probably a UI issue. Let me check & fix this.

sureshanaparti · 2024-06-25T20:01:34Z

@blueorangutan package

blueorangutan · 2024-06-25T20:02:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-06-25T20:56:33Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10125

sureshanaparti · 2024-06-26T05:14:29Z

@blueorangutan package

blueorangutan · 2024-06-26T05:16:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-06-26T06:24:12Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10134

slavkap

Code LGTM, I tested the scenarios that I mentioned above.
I'm not sure what should be the behavior for the templates in the community section in the Deploy VM wizard. If I have a project and download a template, then create another project, the second project has access to the template of the first one via the community tab

sureshanaparti · 2024-06-26T06:39:02Z

Verified listing of templates in default view and projects.

* Honour listall param for list templates api * Don't show templates from another project inside a project view

Honour listall param for list templates api

423362d

boring-cyborg bot added the component:UI label Jun 25, 2024

vishesh92 marked this pull request as ready for review June 25, 2024 08:33

vishesh92 requested review from slavkap and sureshanaparti June 25, 2024 08:33

vishesh92 mentioned this pull request Jun 25, 2024

remove Project Template Permissions inhibition #9196

Merged

13 tasks

vishesh92 added this to the 4.19.1.0 milestone Jun 25, 2024

sureshanaparti approved these changes Jun 25, 2024

View reviewed changes

sureshanaparti requested a review from DaanHoogland June 25, 2024 08:51

yadvr reviewed Jun 25, 2024

View reviewed changes

Comment thread server/src/main/java/com/cloud/api/query/QueryManagerImpl.java

sureshanaparti requested a review from shwstppr June 26, 2024 03:53

sureshanaparti added the status:needs-testing label Jun 26, 2024

sureshanaparti self-assigned this Jun 26, 2024

Don't show templates from another project inside a project view

b9a6ec7

vishesh92 force-pushed the fixup-list-templates branch from 1f7aba4 to b9a6ec7 Compare June 26, 2024 05:08

sureshanaparti added the Severity:BLOCKER label Jun 26, 2024

slavkap approved these changes Jun 26, 2024

View reviewed changes

sureshanaparti merged commit 4f85c3f into apache:4.19 Jun 26, 2024

DaanHoogland deleted the fixup-list-templates branch June 26, 2024 06:44

vishesh92 mentioned this pull request Jun 28, 2024

Revert listAll behaviour for templates & iso #9309

Merged

14 tasks

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 2, 2024

Honour listall param for list templates api (apache#9300)

7639548

* Honour listall param for list templates api * Don't show templates from another project inside a project view

DaanHoogland removed the status:needs-testing label Jan 28, 2026

Conversation

vishesh92 commented Jun 25, 2024

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

vishesh92 commented Jun 25, 2024

Uh oh!

blueorangutan commented Jun 25, 2024

Uh oh!

codecov bot commented Jun 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Jun 25, 2024

Uh oh!

Uh oh!

slavkap commented Jun 25, 2024

Uh oh!

vishesh92 commented Jun 25, 2024

Uh oh!

sureshanaparti commented Jun 25, 2024

Uh oh!

blueorangutan commented Jun 25, 2024

Uh oh!

blueorangutan commented Jun 25, 2024

Uh oh!

sureshanaparti commented Jun 26, 2024

Uh oh!

blueorangutan commented Jun 26, 2024

Uh oh!

blueorangutan commented Jun 26, 2024

Uh oh!

slavkap left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti commented Jun 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Jun 25, 2024 •

edited

Loading